Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kart upgrade command is too eager to help #918

Closed
olsen232 opened this issue Oct 6, 2023 · 1 comment
Closed

kart upgrade command is too eager to help #918

olsen232 opened this issue Oct 6, 2023 · 1 comment

Comments

@olsen232
Copy link
Collaborator

olsen232 commented Oct 6, 2023

Kart's logic for determining what type and version of repository it is operating needs improvement - if a repo mostly lacks internal Kart markers, Kart is too willing to decide that it is a Kart V1 repository and that it needs upgrading. One way to reproduce:

$ kart clone https://github.com/koordinates/kart.git 
$ cd kart
$ kart log
Error: This Kart repo uses Datasets v1 ...

(Note that koordinates/kart is a Git repo, not a Kart repo).

This is a particularly poor guess on Kart's part now that there are basically no V1 repos in existence outside of test data, so guessing the opposite would basically always be right.

This only happens when using Kart to clone the repo - if Git is used to do the cloning operation, Kart will correctly error with:
Error: Current directory is not an existing Kart repository

@olsen232
Copy link
Collaborator Author

olsen232 commented Oct 9, 2023

Fixed by #920

@olsen232 olsen232 closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant