Skip to content
This repository has been archived by the owner on Oct 3, 2024. It is now read-only.

Conflict with new ngOptions in Angular 1.4 #9

Closed
demetriusnunes opened this issue Jun 18, 2015 · 3 comments
Closed

Conflict with new ngOptions in Angular 1.4 #9

demetriusnunes opened this issue Jun 18, 2015 · 3 comments

Comments

@demetriusnunes
Copy link

Hi there,

After we updated to Angular 1.4, ngCropper stopped working due to a conflict with the new ngOptions in Angular 1.4.

A simple change to the directive scope definition to { scope: { options: '=ngCropperOptions' } } fixed the problem.

Would you fix that and release a Angular 1.4 compatible version? Thanks, awesome lib.

@koorgoo
Copy link
Owner

koorgoo commented Jun 23, 2015

Due to some legacy code I still use 1.26 in production.
Will change to support both angular versions soon.
Thanks for reply @demetriusnunes

@code-simian
Copy link

I've also had some issues with making the options have any effect on the cropper.

The only options that seem to work right now for me are 'maximize' and 'aspectRatio'. Even in the demo, if I add more options they have no effect whatsoever. In our work project we are using Angular 1.3 and I see that the demo project is using Angular 1.2 and in both cases the options do not work.

EDIT: the options do work after all. There is a comment in your demo linking to https://github.com/fengyuanchen/cropper#options. Those option names are for the latest version of the jQuery cropper but the one that your project uses is an older version so there is some mismatch between what the linked documentation says and what ngCropper recognizes.

@koorgoo
Copy link
Owner

koorgoo commented Jun 26, 2015

Fixed in ff41008.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants