Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find unlinked files should ignore Thumbs.db etc. #373

Closed
koppor opened this issue Nov 21, 2019 · 8 comments · Fixed by JabRef/jabref#8800
Closed

Find unlinked files should ignore Thumbs.db etc. #373

koppor opened this issue Nov 21, 2019 · 8 comments · Fixed by JabRef/jabref#8800

Comments

@koppor
Copy link
Owner

koppor commented Nov 21, 2019

Use case:

  1. git init
  2. git add library.bib
  3. Have PDF files within that directory
  4. Execute "find untlinked" files

Then all files .git are offered, too

  • Basic implementation: Ignore a hard-coded list of files
  • Advanced implementation: Read .gitignore in the root of the library path and obey it.
@koppor
Copy link
Owner Author

koppor commented Jan 9, 2020

In my use-case blocked by JabRef#3626

@koppor koppor changed the title Find unlinked files should ignore Thumbds.db etc. Find unlinked files should ignore Thumbs.db etc. Sep 22, 2021
@calixtus
Copy link
Collaborator

The user can choose between the options .pdf and . (All files). Imho one should get all files if one chooses all files. A clean solution for this issue would be to create an extra textfield "exclude files": ".sys;thumbs.db"...

@mariotachikawa
Copy link

mariotachikawa commented Oct 27, 2021

I have some questions about this issue:

  • when should the files be ignored (git or in jabref?)
  • where should the execute "find unlinked files" be?
  • should the end user of Jabref use this or is it only for development?
  • besides Thumbs.db, what other files should be ignored?

In general, our university group is not sure if we understand this issue correctly. It would be helpful, if we could get some more details about the problem, if possible.

@calixtus
Copy link
Collaborator

calixtus commented Nov 2, 2021

Hi, sorry for the delay, just had some very stressful days. About your questions:

  1. The files should be ignored when jabref is scanning for unlinked (attachable to an entry) files. Jabref should maybe read .git or .gitignore to know, which files should be ignored in a directory to scan.
  2. There exists a dialog called "Find unlinked files" which already provides the scan logic etc. It should be easy to expand the logic to create a list of files to ignore
  3. The end-user should be able to enable or disable some ignore option or have a list presented with files or filetypes to be ignored
  4. See answer 1. Maybe be creative too.

Godspeed!

@prashant1712
Copy link

Hi, we are a group of students studying Master of Computer Science in University of Adelaide and we wanted to check if this issue is available/open for us to work on for our assignment.

@calixtus
Copy link
Collaborator

Since I did not hear about the other developer for months I believe this issue should be available to be solved.
Please remember to prepare your workspace according to our developer docs (especially checkstyle) so we can prevent a lot of questions and issue in the review process. Feel free to ask questions in our Gitter channel, if you don't understand something!

Have fun coding!

@prashant1712
Copy link

Thank you for your response. We'll start with the issue and we expect to submit the pull request by the first week of May 2022.

@calixtus
Copy link
Collaborator

Ok. The other dev thought he had to implement a completely new dialog. This is not necessary. Goal is to improve the existing one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants