-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FieldComparator vs. EntryComparator #497
Comments
I'll view this as a bit of a mid-length project. Preliminarily I am looking at
and it seems that Most of them are essentially unchanged in the last 8 years (i.e., they are pre-GitHub) so I'll take a look at modernizing the ones I believe need it. The changes should lead to a lot less code that is more readable (❤️ Java 8+) so I'd guess it is a one PR change. Todo
|
Should the PR go here or in the |
I fully agree. Therefore I woud open the PR against |
The
EntryComparator
does not call theFieldComparator
.Why?
Should be fixed. - At least JavaDoc should added referencing each other and explaining the differences.
Refs JabRef#7708
The text was updated successfully, but these errors were encountered: