Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error when testing SpatialConvFistaL1 #36

Open
zhangguoxiao opened this issue Mar 7, 2016 · 1 comment
Open

error when testing SpatialConvFistaL1 #36

zhangguoxiao opened this issue Mar 7, 2016 · 1 comment

Comments

@zhangguoxiao
Copy link

Hi:
As I try to test SpatialConvFistaL1,I find that the code in line 59 is wrong.So I change the code as:
local conntable = nn.tables.full(params.nfiltersout, params.nfiltersin)
mlp = unsup.SpatialConvFistaL1(conntable, params.kernelsize, params.kernelsize, params.inputsize, params.inputsize, params.lambda)
data:conv()
The error message is :stack traceback:
[C]: in function 'copy'
/home/systex/torch/install/share/lua/5.1/unsup/FistaL1.lua:113: in function 'updateOutput'
demo_fista.lua:71: in function 'updateSample'
demo_fista.lua:82: in function 'train'
Finally I find out that the code in 113 in FistaL1.lua seem to be wrong.Am I right?or how should I make thing right!

@zhangguoxiao
Copy link
Author

I change the code in line 86 of file FistaL1.lua to :
if params.inputsize == params.kernelsize and params.conv == false then
serr, siter = updateSample(example[1], example[2] ,currentLearningRate)
else
icode=torch.Tensor(params.nfiltersout):zero()
serr, siter = updateSample(example[1], icode ,currentLearningRate)
end
It works!But I don't think it is a good solution!Any suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant