Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholders are only replaced once #435

Open
ggwpez opened this issue Sep 9, 2024 · 0 comments
Open

Placeholders are only replaced once #435

ggwpez opened this issue Sep 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ggwpez
Copy link

ggwpez commented Sep 9, 2024

Describe the bug

Having a description that contains ${pull_number} more than once only results it in being replaced once.
Example here: paritytech/polkadot-sdk#5634

Screenshot 2024-09-09 at 14 05 34

You can see the placeholder only being replaced once.

To Reproduce
Use a placeholder more than once.

Expected behavior
Should replace it everywhere.

Additional context

It should probably use replaceAll instead of replace here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant