Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💔 ERROR: Check if the vertical metrics of a family are similar to the same family hosted on Google Fonts. #28

Closed
kosbarts opened this issue Apr 24, 2020 · 3 comments

Comments

@kosbarts
Copy link
Owner

--- Rationale ---

If the family already exists on Google Fonts, we need to ensure that the
checked family's vertical metrics are similar. This check will test the
following schema which was outlined in Fontbakery issue #1162 [1]:

  • The family should visually have the same vertical metrics as the
    Regular style hosted on Google Fonts.
  • If the family on Google Fonts has differing hhea and typo metrics,
    the family being checked should use the typo metrics for both the
    hhea and typo entries.
  • If the family on Google Fonts has use typo metrics not enabled and the
    family being checked has it enabled, the hhea and typo metrics
    should use the family on Google Fonts winAscent and winDescent values.
  • If the upms differ, the values must be scaled so the visual appearance
    is the same.

[1] fonttools/fontbakery#1162

💔 ERROR The condition FontBakeryCondition:remote_styles had an error: FailedConditionError: The condition FontBakeryCondition:familyname_with_spaces had an error: TypeError: expected string or bytes-like object

@kosbarts
Copy link
Owner Author

@felipesanches Same as Issue#26. Unreleased project. Why does it report an Error?

@felipesanches
Copy link

A FAIL is a problem with the font, while an ERROR is a problem with the tool (FontBakery) itself. Please update FB to the latest version and report a bug if the problem persists.

@kosbarts
Copy link
Owner Author

@felipesanches sweet mate! All Errors are gone after the update. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants