fix: rewrited callback func in promise from callback func

fixed to wait until webpack compilation or serving process is complete.
kotarella1110 · Sep 19, 2019 · fd493bf · fd493bf
1 parent 502be4f
commit fd493bf
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 16 deletions.
diff --git a/src/webpackCompile.ts b/src/webpackCompile.ts
@@ -23,16 +23,18 @@ module.exports = async (ctx: any) => {
     argv.webpackConfig || argv.w,
   );
   const compiler = webpack(customWebpackConfig);
-
-  compiler.run((err, stats) => {
-    if (err) {
-      throw err;
-    }
-    console.log(
-      stats.toString({
-        chunks: false,
-        colors: true,
-      }),
-    );
+  await new Promise((resolve, reject) => {
+    compiler.run((err, stats) => {
+      if (err) {
+        reject(err);
+      }
+      console.log(
+        stats.toString({
+          chunks: false,
+          colors: true,
+        }),
+      );
+      resolve();
+    });
   });
 };
diff --git a/src/webpackServe.ts b/src/webpackServe.ts
@@ -133,10 +133,13 @@ module.exports = async (ctx: any) => {
 
   const compiler = webpack(webpackConfig);
   const server = new WebpackDevServer(compiler, devServerConfig);
-  server.listen(port, host, err => {
-    if (err) {
-      throw err;
-    }
-    console.log('Starting the development server...\n');
+  await new Promise((resolve, reject) => {
+    server.listen(port, host, err => {
+      if (err) {
+        reject(err);
+      }
+      console.log('Starting the development server...\n');
+      resolve();
+    });
   });
 };