Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middle click switch between kelvin and brightness #17

Open
jornmo opened this issue Mar 26, 2016 · 5 comments
Open

Middle click switch between kelvin and brightness #17

jornmo opened this issue Mar 26, 2016 · 5 comments

Comments

@jornmo
Copy link

jornmo commented Mar 26, 2016

I find my self adjusting the brightness very often, and it is a bit of a hazzle to open the settings panel to do it. How about middle clicking the icon switches modes between kelvin and brightness so that both can quickly be adjusted by using the mouse wheel?

@kotelnik
Copy link
Owner

kotelnik commented Apr 5, 2016

Sorry for my late response.

If I understand it right: middle click would change between temperature mode and brightness mode. Temperature mode would behave exactly the same like it does now. When in "brightness mode" wheel would change brightness without stopping redshift from automatically adjusting temperature. Is that correct?

@jornmo
Copy link
Author

jornmo commented Jan 2, 2017

That sounds like what I had in mind :)

@kotelnik
Copy link
Owner

I've finally did this middle click switch only to realise that it behaves just like screen temperature manual setting (by wheel). That means for now it stops redshift from being updated continuously and just keep it in current temperature forever. I'll fix that soon.

@jornmo
Copy link
Author

jornmo commented Feb 10, 2017

Well, the settings dialogue lets you define the brightness for the continuous mode, so I think it makes sense that the manual brightness goes along with the manual temperature?!

As a "compromise", how about the middle click does nothing about the continuous mode, but it only sets the brightness for the current running mode, i.e. custom or continuous. But, in my mind, that would make less sense though :)

@kotelnik
Copy link
Owner

I was working on the "compromise" version. But it is actually more complicated then I thought. I can see 2 problems with this approach:

  1. Updating continuous mode has to be preceded by ending redshift -> this causes the screen to flash and also takes more miliseconds (mouse wheel is too fast)
  2. Some users have smooth transitions enabled so the live-previewing of changed brightness would be accompanied by constant reset and change of screen temperature

How about sticking to the current situation and adding 2 right-click menu actions:

  • "use current brightness" (to allow current manually set brightness use in continuous mode)
  • "reset brightness" (set brightness from settings)

Triggering such action would cause only one screen flash, like when applying setting changes. Of course I'm open to other ideas:).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants