Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support no game cores #8

Open
FlorianUekermann opened this issue Jan 28, 2019 · 1 comment
Open

Support no game cores #8

FlorianUekermann opened this issue Jan 28, 2019 · 1 comment

Comments

@FlorianUekermann
Copy link

Supporting no-game cores should be easy. I didn't send a patch, because there are some decisions to be made. I would suggest adding a support_no_game: bool to CoreInfo and either turning the game_data argument in on_load_game( &mut self, game_data: libretro_backend::GameData ) into an option, or simply setting its fields to None.

@koute
Copy link
Owner

koute commented Jan 30, 2019

Since GameData is already designed as a container which can be empty I think it would be more natural to just set the fields to None, and adding fn supports_no_game( mut self ) -> Self to CoreInfo sounds fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants