-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please fix: lengths encoding, fixed-size arrays and references #28
Comments
The first point is a feature, not a bug. If you need to store more than 2^32 elements you can always use the Points (2) and (3) are indeed reasonable and could indeed be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
T::minimum_bytes_needed()
for some types returns hardcoded values, instead of values based onsize_of::<T>()
, which leads to errors on 64-bits machines. For example, encoding aBTreeSet
with more than 2**32 elements won't work properly.Now
Readable
andWritable
are only implemented for fixed-size arrays up to 16. Please use generic const expressions and implement them for any size array.Readable
andWritable
are not implemented for&[u8]
and similar types which is a shame.Please, consider fixing these issues. If you need a PR, I can provide you with one.
The text was updated successfully, but these errors were encountered: