Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special HLint check for relude #325

Open
vrom911 opened this issue Jun 1, 2019 · 1 comment
Open

Special HLint check for relude #325

vrom911 opened this issue Jun 1, 2019 · 1 comment
Labels
enhancement generated project Files, folder generation by the summoner

Comments

@vrom911
Copy link
Member

vrom911 commented Jun 1, 2019

No description provided.

@vrom911 vrom911 added generated project Files, folder generation by the summoner enhancement labels Jun 1, 2019
@vrom911 vrom911 added this to the v1.3.0: Extended scaffolding milestone Jun 1, 2019
@chshersh
Copy link
Contributor

This issue is related to #411. On our CI we specify relude version from git tag, like this:

- curl https://raw.githubusercontent.com/kowainik/relude/v0.6.0.0/.hlint.yaml -o .hlint-relude.yaml

If we implement #411, we can insert a version for the tag instead of using master by default. But this means that we won't be able to accept flexible version constraints like >= 0.5.0 && 0.7 (because we can't extract the specific version from these constraints). Alternative solution: since this is only for relude, we can do something smarter and extract all releases for relude and get the version for the latest one. Not sure it worth the complexity, need to think...

@chshersh chshersh removed this from the v2.0: Major update milestone Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement generated project Files, folder generation by the summoner
Projects
None yet
Development

No branches or pull requests

2 participants