Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustls::ServerCertVerifier should check remote_public_key #11

Open
kpp opened this issue Aug 5, 2021 · 0 comments
Open

rustls::ServerCertVerifier should check remote_public_key #11

kpp opened this issue Aug 5, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@kpp
Copy link
Owner

kpp commented Aug 5, 2021

According to https://github.com/libp2p/specs/blob/master/tls/tls.md#libp2p-public-key-extension, the given remote_public_key should be checked inside ServerCertVerifier::verify_server_cert against P2pExtension::public_key:

The public host key allows the peer to calculate the peer ID of the peer it is connecting to. Clients MUST verify that the peer ID derived from the certificate matches the peer ID they intended to connect to, and MUST abort the connection if there is a mismatch.
@kpp kpp added the bug Something isn't working label Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kpp