Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create StarlarkScript CRD for starlark function #1560

Open
mengqiy opened this issue Mar 17, 2021 · 1 comment
Open

Create StarlarkScript CRD for starlark function #1560

mengqiy opened this issue Mar 17, 2021 · 1 comment
Labels
area/fn-catalog Functions Catalog triaged Issue has been triaged by adding an `area/` label

Comments

@mengqiy
Copy link
Contributor

mengqiy commented Mar 17, 2021 •
edited
Loading

Currently we have StarlarkRun which can have a starlark script inline.
In the future, we want to have StarlarkScript to wrap a starlark script and StarlarkRun can reference it with optional key-value parameters.
This solves the reusability issue.
@mengqiy mengqiy added area/fn-catalog Functions Catalog triaged Issue has been triaged by adding an `area/` label labels Mar 17, 2021
@mikebz mikebz added this to the v1.0 m3 milestone Mar 31, 2021
@mengqiy mengqiy mentioned this issue May 5, 2021
Closed
@mikebz mikebz modified the milestones: v1.0 m3, v1.0 m4 May 25, 2021
@mikebz mikebz removed this from the v1.0 m4 milestone Jul 14, 2021
@mengqiy mengqiy mentioned this issue Sep 14, 2021
Open
@yuwenma
Copy link
Contributor

yuwenma commented Jan 29, 2022

@mengqiy Do you think this can be achieved if we support the include-file #2350 so no new CRD is needed.

@mortent mortent added this to kpt Jan 21, 2023
@mortent mortent moved this to Backlog in kpt Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/fn-catalog Functions Catalog triaged Issue has been triaged by adding an `area/` label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikebz @mengqiy @yuwenma