Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dumb http servers not supported #2352

Open
justinsb opened this issue Jun 30, 2021 · 1 comment
Open

dumb http servers not supported #2352

justinsb opened this issue Jun 30, 2021 · 1 comment
Labels
area/pkg bug Something isn't working help wanted Extra attention is needed p2 size/M 2 day triaged Issue has been triaged by adding an `area/` label

Comments

@justinsb
Copy link
Contributor

Expected behavior

kpt should be able to clone from dumb http servers

Actual behavior

Fetching https://<foo>.storage.googleapis.com/kpt@main
fatal: dumb http transport does not support shallow capabilities
Error: Failed to execute git command "git origin origin --depth=1 main" against repo "https://<foo>.storage.googleapis.com/kpt" for reference "main" 

Details:
fatal: dumb http transport does not support shallow capabilities 

Information

Dumb http transports do not support shallow clones; we should likely retry with a non-shallow clone if the shallow clone fails. I don't know if there's a nice way to detect the error other than looking for a magic string.

Steps to reproduce the behavior

Try cloning a repo on a dumb http server; I can provide an example if needed!

@justinsb justinsb added the bug Something isn't working label Jun 30, 2021
@mortent mortent added area/pkg triaged Issue has been triaged by adding an `area/` label size/M 2 day labels Jun 30, 2021
@mortent
Copy link
Contributor

mortent commented Jun 30, 2021

Ideally we want to avoid relying on retries, as it means commands tends to be very slow and also complicates the UX. We currently pipe some of the output from git to the terminal to give users some more information about progress. Maybe there is a way we can check if the git remote is smart or dumb, and then choose the right approach on the first try. I haven't tried this out, but seems like there might be something we can do: https://stackoverflow.com/questions/9270488/is-it-possible-to-detect-whether-a-http-git-remote-is-smart-or-dumb/10661345

@droot droot added p2 help wanted Extra attention is needed labels May 27, 2022
@mortent mortent added this to kpt Jan 21, 2023
@mortent mortent moved this to Backlog in kpt Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/pkg bug Something isn't working help wanted Extra attention is needed p2 size/M 2 day triaged Issue has been triaged by adding an `area/` label
Projects
None yet
Development

No branches or pull requests

3 participants