Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function autocomplete should read catalog from OCI annotation or Docker label #2870

Open
yuwenma opened this issue Mar 4, 2022 · 1 comment
Assignees
Labels
area/fn-catalog Functions Catalog area/hydrate enhancement New feature or request p2 triaged Issue has been triaged by adding an `area/` label

Comments

@yuwenma
Copy link
Contributor

yuwenma commented Mar 4, 2022

The function autocomplete catalog is hosted in https://catalog.kpt.dev/catalog-v2.json

The value is parsed from each function's metadata.yaml (see example) .

We should

  1. change functions to store info in the OCI annotation or docker label once available
  2. change the function autocomplete catalog to get metadata from OCI and docker accordingly.
  3. Add --type=[m(utator)|v(alidator)] flag to kpt fn eval to filter corresponding type in auto completion and save to the corresponding kptfile once --save is used.

related to #2333

@yuwenma yuwenma added the enhancement New feature or request label Mar 4, 2022
@yuwenma
Copy link
Contributor Author

yuwenma commented Mar 10, 2022

Per offline discussion, since kpt does not have short term plan to execute OCI KRM functions, we would not have autocomplete supporting the OCI annotation. Only add docker labels to the meta.

@droot droot added the triaged Issue has been triaged by adding an `area/` label label Mar 11, 2022
@droot droot added p2 triaged Issue has been triaged by adding an `area/` label and removed triaged Issue has been triaged by adding an `area/` label labels May 17, 2022
@droot droot added area/fn-catalog Functions Catalog area/hydrate labels May 27, 2022
@mortent mortent added this to kpt Jan 21, 2023
@mortent mortent moved this to Backlog in kpt Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fn-catalog Functions Catalog area/hydrate enhancement New feature or request p2 triaged Issue has been triaged by adding an `area/` label
Projects
None yet
Development

No branches or pull requests

2 participants