Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

porch: additional concurrency tests #4003

Open
johnbelamaric opened this issue Jul 8, 2023 · 1 comment
Open

porch: additional concurrency tests #4003

johnbelamaric opened this issue Jul 8, 2023 · 1 comment
Labels
area/porch enhancement New feature or request

Comments

@johnbelamaric
Copy link
Contributor

Describe your problem

In #3993 we added checks for resource version. This should help a lot, but it's probably not sufficient. For example, I suspect since we don't acquire a pacakgerevision mutex, you could still have a race condition where two simultaneous update calls came in and bypassed each others resource version checks. Similarly, I am not sure whether we have mutex on the package revision / package revision resources when we do our multi-commit saves (maybe we do have this?).

In any case, I suspect there is still a fair bit of work to do to make sure all concurrency issues are resolved, so I am raising this issue to track that work.

@johnbelamaric johnbelamaric added the enhancement New feature or request label Jul 8, 2023
@github-project-automation github-project-automation bot moved this to Backlog in kpt Jul 8, 2023
@johnbelamaric
Copy link
Contributor Author

See also: #3993 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/porch enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants