Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kpt fn sink should allow merge strategies #954

Open
frankfarzan opened this issue Aug 18, 2020 · 2 comments
Open

kpt fn sink should allow merge strategies #954

frankfarzan opened this issue Aug 18, 2020 · 2 comments
Labels
area/hydrate catalog-blocker enhancement New feature or request size/XL 8 day triaged Issue has been triaged by adding an `area/` label

Comments

@frankfarzan
Copy link
Contributor

Similar to kpt pkg update.

It's not desirable to always overwrite the sink directory.

Note that kpt fn run also implicitly invokes sink.

@monopole
Copy link
Contributor

Do you have a specific example in mind?

@mortent
Copy link
Contributor

mortent commented Aug 24, 2020

@monopole
So an example would be using kpt with Helm. I use a kpt function to hydrate the Helm chart into yaml and I take the result as a Kpt package. This means I can create setters/substitutions and maybe make some manual changes. Eventually there will be a new version of the Helm chart and I would like to update my kpt package. I would like to run the same kpt function again to hydrate the Helm chart, but I also need the merge logic from kpt pkg update to incorporate the changes into my package.
The workaround for this now is that I can make a intermediate git repo where I commit the hydrated Helm chart before using that as the source for updating my kpt package. This seems unnecessarily cumbersome.

@mortent mortent added size/XL 8 day triaged Issue has been triaged by adding an `area/` label labels Aug 24, 2020
@droot droot added the enhancement New feature or request label Jan 5, 2021
@phanimarupaka phanimarupaka self-assigned this Aug 22, 2021
@mortent mortent added this to kpt Jan 21, 2023
@mortent mortent moved this to Backlog in kpt Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hydrate catalog-blocker enhancement New feature or request size/XL 8 day triaged Issue has been triaged by adding an `area/` label
Projects
None yet
Development

No branches or pull requests

5 participants