Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve plural suffix support #402

Closed
jacobtomlinson opened this issue Jun 11, 2024 · 0 comments · Fixed by #403
Closed

Improve plural suffix support #402

jacobtomlinson opened this issue Jun 11, 2024 · 0 comments · Fixed by #403
Labels
bug Something isn't working

Comments

@jacobtomlinson
Copy link
Member

Which project are you reporting a bug for?

kr8s

What happened?

Following on from #391 there are still some issues with plural suffixes as we assume they will always be appended to the singular name.

pod => pods
ingress => ingresses

However some may modify the ending letter.

policy => policies

Instead of trying to be smart it might be better to just allow folks to pass the plural in.

Anything else?

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow explicit passing of plural name to new_class instead of suffix jacobtomlinson/kr8s
1 participant
@jacobtomlinson