Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Test ending after typing one character. #74

Closed
NextStep-IM opened this issue Feb 5, 2024 · 17 comments
Closed

[BUG] Test ending after typing one character. #74

NextStep-IM opened this issue Feb 5, 2024 · 17 comments
Labels
bug Something isn't working

Comments

@NextStep-IM
Copy link

Describe the bug 🐛

This bug starts occurring after doing the first test at startup. The test ends after typing a character.

To Reproduce 🐣

  1. Start smassh.
  2. Do a test.
  3. Do a test again.

Expected behavior 🤔

No response

Screenshots 🧐

smassh.webm

Your operating system name

Arco Linux

Your operating system version

6.7.3-arch1-2

Additional context 📝

No response

@NextStep-IM NextStep-IM added the bug Something isn't working label Feb 5, 2024
@SwayKh
Copy link

SwayKh commented Feb 5, 2024

I just Installed this after seeing a post on reddit, Can confirm I am getting this same issue.

Need to close the app and restart again to be able to type again.

@kraanzu
Copy link
Owner

kraanzu commented Feb 5, 2024

Hmm... strange.
How did you install?

@NextStep-IM
Copy link
Author

NextStep-IM commented Feb 5, 2024

I installed using pipx. Wanted to install through AUR but it was giving me some error.

Edit: The AUR version also has the same bug.

@kraanzu
Copy link
Owner

kraanzu commented Feb 5, 2024

I installed using pipx

Can you check the version using smassh --version

I'm not able to reproduce with the latest build

@NextStep-IM
Copy link
Author

NextStep-IM commented Feb 5, 2024

Can you check the version using smassh --version

3.0.4

@kraanzu
Copy link
Owner

kraanzu commented Feb 5, 2024

Need to close the app and restart again to be able to type again.

According to @SwayKh, he's able to type if he restarts the app. Is that the case for you as well?

@NextStep-IM
Copy link
Author

Is that the case for you as well?

Yep

@kraanzu
Copy link
Owner

kraanzu commented Feb 5, 2024

Ok one last thing, can you delete the config file and restart the app?

python -c "import appdirs; print(appdirs.user_data_dir('smassh'))"

Should be ~/.config/smassh/smassh.json for you

There are three settings (first three ones) which will end the typing if certain conditions are not met (speed/accuracy)
Maybe you turned on those :)

image

@NextStep-IM
Copy link
Author

NextStep-IM commented Feb 5, 2024

There are three settings (first three ones) which will end the typing if certain conditions are not met (speed/accuracy)
Maybe you turned on those :)

Right on target.
This was my config:

{"difficulty": "normal", "blind_mode": false, "min_speed": 2, "min_accuracy": 0, "min_burst": 0, "force_correct": false, "confidence_mode": "off", "capitalization_mode": "off", "cursor_buddy_speed": 0, "tab_reset": false, "language": "english", "numbers": false, "punctuations": false, "mode": "words", "words_count": 30, "time_count": 30, "caret_style": "block", "writing mode": "words", "theme": "catppuccin"}

Fresh config after deleting:

{"difficulty": "normal", "blind_mode": false, "min_speed": 0, "min_accuracy": 0, "min_burst": 0, "force_correct": false, "confidence_mode": "off", "capitalization_mode": "off", "cursor_buddy_speed": 0, "tab_reset": false, "language": "english", "numbers": false, "punctuations": false, "mode": "words", "words_count": 30, "time_count": 30, "caret_style": "block", "writing mode": "words", "theme": "nord"}

min_speed was the culprit.

@NextStep-IM
Copy link
Author

Thanks a lot, @kraanzu!

@kraanzu
Copy link
Owner

kraanzu commented Feb 5, 2024

Awesome!
Thing is you have to do a quick start on this one otherwise the calculation done is quite low
Maybe I should add a timeout or something or maybe at least show on result screen that the test ended due to the setting :)

@SwayKh
Copy link

SwayKh commented Feb 5, 2024

Yup, The min speed setting was set to 1, Changing that to 0 corrected the behaviour.

Seems weird that the setting was enabled by default, Tried both AUR and pipx.
Glad the issue was solved so quickly.

Great App BTW, Love it.

@kraanzu
Copy link
Owner

kraanzu commented Feb 5, 2024

Seems weird that the setting was enabled by default,

Nope! Maybe you accidently pressed tab key on settings screen :)

@kraanzu
Copy link
Owner

kraanzu commented Feb 5, 2024

Anyways, I'll close this issue now then
Thanks for giving smassh a try 😄 ❤️

@kraanzu kraanzu closed this as completed Feb 5, 2024
Copy link

github-actions bot commented Feb 5, 2024

Did we solve your problem?

Glad we could help!
Don't forget to star the repository!
@kraanzu

@SwayKh
Copy link

SwayKh commented Feb 5, 2024

Nope! Maybe you accidently pressed tab key on settings screen :)

Oops, I apologize, It seems I might have done that when testing the settings and keys

@kraanzu
Copy link
Owner

kraanzu commented Feb 5, 2024

No problemo! I'll fix this so it doesn't end the test that quick :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants