Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for streams #10

Open
ebdrup opened this issue Jun 1, 2016 · 1 comment
Open

Support for streams #10

ebdrup opened this issue Jun 1, 2016 · 1 comment

Comments

@ebdrup
Copy link

ebdrup commented Jun 1, 2016

Hi when doing a request with for example the request module, sometimes you want to do the request as streams and pipe the response. Meaning that there is no callback, instead you have to watch for the stream returned by request.get being destroyed (maybe with an error).

It would be awesome if levee supported streaming.

Basically breaker.run will return a stream and you have to attach to .on('close', ...) and .on('error', ...), etc. for breaking/timeout etc.

The module end-of-stream would be handy for this.

@tlivings
Copy link
Contributor

tlivings commented Dec 8, 2016

I've been working on optional callbacks and return values. I actually have a PR open for returning result from underlying function call, but optional callbacks will likely require a new API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants