Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a changelog #108

Open
bluepnume opened this issue Jul 13, 2017 · 11 comments
Open

Add a changelog #108

bluepnume opened this issue Jul 13, 2017 · 11 comments

Comments

@bluepnume
Copy link
Collaborator

Plenty of people using this now... can't do it cowboy style any more!

@harouny
Copy link
Contributor

harouny commented Jul 26, 2017

Hey @bluepnume
We currently have v 2 in production for couple of projects. We need to have the list of breaking changes / new features before we can upgrade. Is that something you would be doing?

@bluepnume
Copy link
Collaborator Author

Hey @harouny -- sorry for the delay on this, been tied up with a bunch of high priority things.

I'll add a changelog soon, but for now the only breaking change with v3 was to do with the containerTemplate and componentTemplate options.

Instead of passing a string, the recommended approach is now to pass a DOM element (to which you can attach your own events rather than using things like class="${CLASS.CLOSE}".

There's an example here -- https://github.com/krakenjs/xcomponent/blob/master/demo/basic/lightbox/login.js#L14-L113

But let me know if you're using either of those options and I can help you migrate if needed.

@twig
Copy link

twig commented Nov 7, 2017

We've recently put xcomponent into production and surprised to see multiple releases in the past 2 days!

image

Would not be able to keep up with development at this rate without change logs.

@apuntovanini
Copy link

apuntovanini commented Jan 24, 2019

Any news on Changelog? v8 came out with no clues yet
Thanks!

@joseluis-fw
Copy link

It will be nice at least to have the PR description and closed issues between releases. Was difficult to link this to this commit in master.

@apuntovanini
Copy link

@bluepnume I do love Zoid, but with no changelog is so difficult to understand what's going on. Why not using @changesets or automatic changelog generators? Open to PR?

@bluepnume
Copy link
Collaborator Author

Hi @apuntovanini — definitely open to PRs!

@rafaeelaudibert
Copy link

rafaeelaudibert commented Oct 4, 2021

Hey @bluepnume, would you assign this to me? I think we could create the CHANGELOG differently than what was proposed before. I'd use a Github action to create it so that every time we create a tag, we would automatically generate a Github Release with its changelog attached (like most of the libs are doing nowadays). WDYT?

I'd probably use this action.

@mstuart
Copy link
Contributor

mstuart commented Oct 4, 2021

That would be great! Thanks @rafaeelaudibert. Assigning to you

@ghost
Copy link

ghost commented Oct 10, 2021

@rafaeelaudibert
Copy link

I've thought about using this @sibiraj-sr, but it is pretty new, and it would need some manual work, with the maintainers needing to manually create the release.

@mstuart, could you check the PR? #373

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants