compile issue RHEL 7.1

[palynche-nokia]

Having problems compiling on RHEL 7.1 anyone seen this before.
yum install autoconf libtool automake pam-devel -y

./configure && make && sudo make install
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking minix/config.h usability... no
checking minix/config.h presence... no
checking for minix/config.h... no
checking whether it is safe to define EXTENSIONS... yes
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) gcc3
checking whether ln -s works... yes
checking whether make sets $(MAKE)... (cached) yes
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to print strings... printf
checking for a sed that does not truncate output... /usr/bin/sed
checking for fgrep... /usr/bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for ar... ar
checking for archiver @file support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for mt... no
checking if : is a manifest tool... no
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... no
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking whether gcc and cc understand -c and -o together... yes
checking for pam_start in -lpam... yes
checking for tac_connect in -ltac... no
checking for MD5_Init in -lcrypto... yes
checking for RAND_pseudo_bytes in -lcrypto... yes
checking for RAND_bytes in -lcrypto... yes
checking for pututxline in -lc... yes
checking for ANSI C header files... (cached) yes
checking arpa/inet.h usability... yes
checking arpa/inet.h presence... yes
checking for arpa/inet.h... yes
checking fcntl.h usability... yes
checking fcntl.h presence... yes
checking for fcntl.h... yes
checking netdb.h usability... yes
checking netdb.h presence... yes
checking for netdb.h... yes
checking netinet/in.h usability... yes
checking netinet/in.h presence... yes
checking for netinet/in.h... yes
checking for stdlib.h... (cached) yes
checking for string.h... (cached) yes
checking for strings.h... (cached) yes
checking sys/socket.h usability... yes
checking sys/socket.h presence... yes
checking for sys/socket.h... yes
checking sys/time.h usability... yes
checking sys/time.h presence... yes
checking for sys/time.h... yes
checking limits.h usability... yes
checking limits.h presence... yes
checking for limits.h... yes
checking syslog.h usability... yes
checking syslog.h presence... yes
checking for syslog.h... yes
checking for unistd.h... (cached) yes
checking openssl/md5.h usability... yes
checking openssl/md5.h presence... yes
checking for openssl/md5.h... yes
checking openssl/rand.h usability... yes
checking openssl/rand.h presence... yes
checking for openssl/rand.h... yes
checking sys/random.h usability... no
checking sys/random.h presence... no
checking for sys/random.h... no
checking security/pam_appl.h usability... yes
checking security/pam_appl.h presence... yes
checking for security/pam_appl.h... yes
checking for an ANSI C-conforming const... yes
checking for size_t... yes
checking whether time.h and sys/time.h may both be included... yes
checking whether CC supports -fstack-protector-all... yes
no
checking whether CC supports -Wl,-z,relro... yes
no
checking whether CC supports -Wl,-z,now... yes
no
checking whether CC supports -fPIE... yes
no
checking whether CC supports -pie... yes
no
checking whether CC supports -U_FORTIFY_SOURCE... yes
no
checking whether CC supports -D_FORTIFY_SOURCE=2... yes
no
checking for stdlib.h... (cached) yes
checking for GNU libc compatible realloc... yes
checking sys/select.h usability... yes
checking sys/select.h presence... yes
checking for sys/select.h... yes
checking for sys/socket.h... (cached) yes
checking types of arguments for select... int,fd_set *,struct timeval *
checking return type of signal handlers... void
checking for bzero... yes
checking for gethostbyname... yes
checking for gettimeofday... yes
checking for inet_ntoa... yes
checking for select... yes
checking for socket... yes
checking for logwtmp... no
checking for getrandom... no
checking for strtol... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating libtac.pc
config.status: creating pam_tacplus.spec
config.status: creating config.h
config.status: config.h is unchanged
config.status: executing depfiles commands
config.status: executing libtool commands
make all-am
make[1]: Entering directory /root/pam_tacplus-master' /bin/sh ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -Wall -Wextra -Werror -I ./libtac/include -g -O2 -MT libtac/lib/libtac_la-acct_r.lo -MD -MP -MF libtac/lib/.deps/libtac_la-acct_r.Tpo -c -o libtac/lib/libtac_la-acct_r.lo test -f 'libtac/lib/acct_r.c' || echo './'libtac/lib/acct_r.c libtool: compile: gcc -DHAVE_CONFIG_H -I. -Wall -Wextra -Werror -I ./libtac/include -g -O2 -MT libtac/lib/libtac_la-acct_r.lo -MD -MP -MF libtac/lib/.deps/libtac_la-acct_r.Tpo -c libtac/lib/acct_r.c -fPIC -DPIC -o libtac/lib/.libs/libtac_la-acct_r.o libtac/lib/acct_r.c: In function 'tac_acct_read': libtac/lib/acct_r.c:49:17: error: pointer targets in assignment differ in signedness [-Werror=pointer-sign] re->msg = xstrdup(acct_syserr_msg); ^ libtac/lib/acct_r.c:60:17: error: pointer targets in assignment differ in signedness [-Werror=pointer-sign] re->msg = xstrdup(acct_syserr_msg); ^ libtac/lib/acct_r.c:69:17: error: pointer targets in assignment differ in signedness [-Werror=pointer-sign] re->msg = xstrdup(msg); ^ libtac/lib/acct_r.c:94:17: error: pointer targets in assignment differ in signedness [-Werror=pointer-sign] re->msg = xstrdup(acct_syserr_msg); ^ libtac/lib/acct_r.c:106:17: error: pointer targets in assignment differ in signedness [-Werror=pointer-sign] re->msg = xstrdup(acct_syserr_msg); ^ libtac/lib/acct_r.c:127:17: error: pointer targets in assignment differ in signedness [-Werror=pointer-sign] re->msg = xstrdup(acct_syserr_msg); ^ libtac/lib/acct_r.c:138:17: error: pointer targets in assignment differ in signedness [-Werror=pointer-sign] re->msg = msg; /* Freed by caller */ ^ libtac/lib/acct_r.c:144:31: error: pointer targets in assignment differ in signedness [-Werror=pointer-sign] if (!re->msg) re->msg = xstrdup(acct_ok_msg); ^ libtac/lib/acct_r.c:155:34: error: pointer targets in assignment differ in signedness [-Werror=pointer-sign] if (!re->msg) re->msg=xstrdup(acct_fail_msg); ^ libtac/lib/acct_r.c:161:34: error: pointer targets in assignment differ in signedness [-Werror=pointer-sign] if (!re->msg) re->msg=xstrdup(acct_err_msg); ^ cc1: all warnings being treated as errors make[1]: *** [libtac/lib/libtac_la-acct_r.lo] Error 1 make[1]: Leaving directory /root/pam_tacplus-master'
make: *** [all] Error 2

[kravietz]

Yes, I have accidentally pushed a change that should go as part of bigger pack. Will revert this.

[palynche-nokia]

Great can test the revert when you post it

[cpclaudio]

Hello Guys,

Is it safe to compile the tacplus with -Werror supressed?

[alextomko]

I am also seeing this issue suddenly now on Debian 9. I have not had any issues for several years until recently.

[alextomko]

How would you compile with Werror suppressed?

[alextomko]

Hello - I was able to edit the Makefile and remove Werror from this line:
AM_CFLAGS = -Wall -Wextra -Werror
I then ran the make install and it installed and is working. Is this OK to do or will it cause other issues?

[romanogit]

Any feedback about this issue? Getting the same error on CentOS 7.6