-
-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discontinued FCM Messaging API #804
Comments
same! |
Related: firebase/firebase-admin-java#834 The official docs still use the batch endpoint, I'll have to investigate the Admin Node SDK, on mobile I didn't yet see what really changed. I'll get to it once I can find some time. For the time being, sending messages "the old way" still seems to work, so I think no immediate action is required. While I'm at it: if your business relies on my SDK, please consider becoming a sponsor, I invest a considerable of time and work into it 🙏🏻 |
Okay, if I'm not mistaken, in the Admin Node SDK, they now use n asynchronous requests to In the PHP SDK, sending a single message already uses the HTTP V1 API, so there's nothing to add. But: all requests in this SDK are currently blocking, this means I cannot just make Implementing this in an asynchronous way will require a considerable amount of thinking and work, and I can't give you an ETA other than "before June 20, 2024". 😅 |
Please don't open a PR for this, reviewing the code and requiring changes would take longer than implementing it myself in a way I feel comfortable maintaining down the road. You can support the development of this change and the maintenance of this library in General by becoming a GitHub Sponsor. |
Alright, I underestimated myself 😂 - I have this working locally and will try to make a (at first dirty) PR for you to test shortly |
Ha-ha, it's so funny.. in a good way. 😂👍
|
What should I say 😅. I do have a lot going on at the moment und just little time, but I had a window of opportunity and went for it 😅 Please test #805 and let me know (preferably in the PR comments) if this works for you - I myself have only two device tokens to test with 😅. |
I started with new methods to replicate what the Node Admin SDK is doing, but that would have introduced a breaking change (adding new methods to the The new implementation of the existing methods are not the prettiest but should™ work and will be released in the next feature release 🤞🏻 |
The docs must be updated too It still says
|
Oh, if it must then I certainly will not oppose it 🫡 (cb59ba0) |
Is there a way to use these changes while our php version is still stuck on 7.4? Unfortunately I cannot update the php version for a few projects. But I'm not sure how to handle the change for the multicast without updating the php version (7.x releases requires php 8.1 and higher right?). The only other way I thought of was to fork the project and make the same changes in an earlier release. But before I take that route I was hoping there was an easier way. |
It might be possible backport it to 6.x, but looking into if it's actually feasible and then doing it, is something that I'm not able/willing to do for free, I hope you understand. I can offer you to do it for at least two consecutive months of my $500 sponsorship tier or an invoice for the same amount to be paid in advance (you asked for an easier way 😄). Given that you've been using the SDK in several projects which probably generated more revenue than that, I consider this a more than fair proposal. You could, of course, fork the project and do it yourself, but depending on how much you value your (team's) work, that might be more expensive. |
@jeromegamez Thanks for the response! Of course I understand, I'm not expecting you to backport it for free. But great that you are willing to do so if we sponsor you! Haha it is indeed an easier way I was not expecting 😉 . I will discuss this with my team to ask them what they would like. Besides that, since we are indeed using it in several projects. I put sponsoring this project on our list to discuss, to sponsor you anyway. |
Thank you so much, I really appreciate it! 🙏🏻 |
Describe the bug
Messaging
sendMulticast()
method uses discontinued Google FCM API.Ref: firebase/firebase-admin-node#2138
Suggest me if there is any alternate solution like using different method to send message to multiple devices.
Installed packages
PHP version and extensions
Steps to reproduce the issue.
Error message/Stack trace
Additional information
I have received a mail from Google to alert me about the usage of discontinued API in one of my project.
The text was updated successfully, but these errors were encountered: