-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning: Undefined array key "mfaEnrollmentId" #783
Comments
Thanks for reporting this - I had implemented this to resolve #749, but I wasn't able to test this properly (and @jesperbjerke, who requested it, might not have either 😅). As far as I can see (from my phone) I can/would not change the existing property as it would be a breaking change, and introduce a new property instead (perhaps Can I rely on you properly testing this for me once I create the according PR? 🙏🏻 |
Firebase supports only phone MFA, so I don't think it's needed to add another property for now as it will only contain the single item which is already there. Instead the property can be passed the only item if present, or null And yes, I'm able to test this for you |
Could you give #784 a try? |
Hello, tested:
works as expected! thank you very much |
Thank you 🙏🏻! I will then hopefully merge and release it later this evening, tomorrow at latest! |
Fixed with 8d82198 |
Thank you for the fix. Awesome package! |
Describe the bug
When 2FA is enabled in Firebase Auth, and a user has enrolled a 2FA method, Auth::listUsers and Auth::getUser throw the following exception
this seems to be caused by the API returning an array of MfaInfo, while the php lib expects only one
I was able to fix with the following changes:
7.x...guillaumesmo:firebase-php:7.x
Installed packages
Steps to reproduce the issue.
Error message/Stack trace
Additional information
No response
The text was updated successfully, but these errors were encountered: