Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom exceptions should extend from StandardError, not Exception #74

Open
simonista opened this issue Dec 18, 2015 · 1 comment
Open

Comments

@simonista
Copy link

see http://blog.honeybadger.io/ruby-exception-vs-standarderror-whats-the-difference/

Exceptions that need to change:

  • InvalidRequestException
  • InvalidResultType
  • InvalidCursor
  • InvalidBindVariable
  • UnescapableObject

I'll try to circle back around with a pull request for this, unless there's a good reason not to make this change?

@kreynolds
Copy link
Owner

There is no reason not to, other than this driver is deprecated now in favor of the official one maintained by datastax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants