Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components' less files aren't being watched #91

Closed
yanivefraim opened this issue Apr 8, 2015 · 5 comments
Closed

Components' less files aren't being watched #91

yanivefraim opened this issue Apr 8, 2015 · 5 comments

Comments

@yanivefraim
Copy link

Inside gulpfile you can find that:
src.styles = 'src/styles/**/*.{css,less}';
while components' less files are held inside
components/{component-name}/{component-name}.less

A simple solution will be to change src.styles to be:
src.styles = 'src/**/*.{css,less}';

This way it will take all less files from within the src folder.

Is it an acceptable solution? If so, I would love to add a PR (:

@koistya
Copy link
Member

koistya commented Apr 10, 2015

@yanivefraim, FYI, the styles Gulp task and ./src/styles/ folder are going to be removed from the project. Currently webpack handles per-component CSS files as described here:

But if you have a similar alternative solution with per-component CSS, please share. Ideally it should support multiple bundles (bundle-splitting), embedding images and other assets similar to what webpack does.

@yanivefraim
Copy link
Author

@koistya, Thanks, I will read some more in order to better understand Webpack.

By the way - I was looking for a cool React/Flux starter kit to work/play with. This was by far the best I found! I was wondering if I could contribute back somehow (issues / take active part in development). I am pretty new to React (playing with it for several months now), after writing Angular.js in the last years

Thanks again!
Yaniv

@koistya
Copy link
Member

koistya commented Apr 10, 2015

@yanivefraim Thanks! And you're welcome to join the project! One of the upcoming tasks/features is to make webpack save stats into a .json file, then use it to rename app.js (client bundle) into app-<hash>.js during a build and make sure that index.html references the correct file, e.g <script src="app-63a7cef.js"></script>. See gulpfile.js > bundle task. Would help me with that? I have many other interesting tasks/features like this one :)

@yanivefraim
Copy link
Author

@koistya Cool! I will love to help with that! I did the exact same think (Static files versioning with .json file holding those versions) at work - only that it was an Angular.js project and I used Grunt.js & grunt-hash-res plugin in order to do so.

Should I do it on a fork? on a feature branch? How can I contact you for questions?

Thanks!
Yaniv

BYW - is this the feature? #59. Can you assign it to me? (:

@koistya
Copy link
Member

koistya commented Feb 21, 2016

I believe this is no longer an issue. Feel free to reopen if needed. Assets versioning is already in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants