Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memwatch Cosmetic Issues #1

Open
rylieb opened this issue Dec 6, 2019 · 2 comments
Open

Memwatch Cosmetic Issues #1

rylieb opened this issue Dec 6, 2019 · 2 comments

Comments

@rylieb
Copy link
Contributor

rylieb commented Dec 6, 2019

Memwatches in KZ have some cosmetic issues, at least in commit: 48b7c66, KZSE full version, Wii VC. It's possible newer commits or different KZ versions might not have the issues.

  1. Memwatches are left-aligned. This causes them to jump horizontally around the screen as the value gets more or fewer digits.
  2. Long memwatch names get corrupted upon reset/profile load.
  3. Deleting memwatches that aren't at the bottom of the list corrupts the memwatch menu.

Unlisted YouTube video with timestamps showing the issues

@krimtonz
Copy link
Owner

krimtonz commented Dec 6, 2019

Thank you for your feedback!

Commit 4fe28f6 fixes issues 2 and 3.

Issue 1 might need some design consideration.

@rylieb
Copy link
Contributor Author

rylieb commented Dec 7, 2019

Thanks for fixing issues 2 and 3!

Regarding issue 1: I've been told GZ aligns memwatches with the decimal point for floats, or with the rightmost numerical digit for integers/hex. I don't play OoT though so it's only word of mouth. If that's too difficult, aligning with the rightmost character in the label would also be preferable to the current state of affairs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants