-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clicking outside the dialog box or on Esc should close it as with X #1
Comments
Oh, good idea. I've just published v3.0.1, which takes care of the mouse click. If you've defined a No escape-key support yet though...watch this space or feel free to PR. :-) (And thanks for the note about the license. Also now fixed. I'd actually never taken in that field in elm-package.json. :-D ) |
I was excited to test it but I see that you are delaying the feature because of bugs. |
@krisajenkins Hi! Thank for the great widget!! You write that if I specify |
This also wasn't working for me, and after looking through where |
Hello,
I don't know how difficult it would be to add this feature and your dialog component is already great without it but if that's not too complicated that would be great because this is the most standard behavior of dialogs on the web.
Thanks!
PS: your README says the license is MIT but your elm-package.json says it is BSD3. These two licenses are quite close but it would be more consistent to mention only one. I suppose this small inconsistency comes from BSD3 being the default license when creating a new package.
The text was updated successfully, but these errors were encountered: