Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking outside the dialog box or on Esc should close it as with X #1

Open
Zimmi48 opened this issue Jun 6, 2016 · 4 comments
Open

Comments

@Zimmi48
Copy link

Zimmi48 commented Jun 6, 2016

Hello,
I don't know how difficult it would be to add this feature and your dialog component is already great without it but if that's not too complicated that would be great because this is the most standard behavior of dialogs on the web.
Thanks!

PS: your README says the license is MIT but your elm-package.json says it is BSD3. These two licenses are quite close but it would be more consistent to mention only one. I suppose this small inconsistency comes from BSD3 being the default license when creating a new package.

@krisajenkins
Copy link
Owner

Oh, good idea. I've just published v3.0.1, which takes care of the mouse click. If you've defined a closeMessage, clicking away will close the modal. (If you haven't, that's how you make dialogs that must be explicitly acknowledged.)

No escape-key support yet though...watch this space or feel free to PR. :-)

(And thanks for the note about the license. Also now fixed. I'd actually never taken in that field in elm-package.json. :-D )

@Zimmi48
Copy link
Author

Zimmi48 commented Jun 7, 2016

I was excited to test it but I see that you are delaying the feature because of bugs.
Thanks anyway, and let me know when this gets any update.
;-)

@wwwater
Copy link

wwwater commented Jun 3, 2018

@krisajenkins Hi! Thank for the great widget!! You write that if I specify closeMessage, then clicking away should close the modal, but it doesn't happen in my case. Could you think of any reason for it?

@jesse-c
Copy link

jesse-c commented Jun 12, 2018

This also wasn't working for me, and after looking through where closeMessage was used, I didn't see how it could. I've made a PR though that's working locally for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants