Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make work with Sidekiq 5 #11

Closed
krisleech opened this issue Mar 21, 2017 · 6 comments
Closed

Make work with Sidekiq 5 #11

krisleech opened this issue Mar 21, 2017 · 6 comments

Comments

@krisleech
Copy link
Owner

krisleech commented Mar 21, 2017

We need to stop using sidekiq's #delay method as this no longer works in Sidekiq 5, see: https://github.com/mperham/sidekiq/wiki/Delayed-extensions

Related to #7

@rromanchuk
Copy link

I think you mean sidekiq 5.x, Rails 5 and sidekiq 4.x work fine 😄

@rromanchuk
Copy link

btw, if anyone is reading this and needs to use 5.0 you can hack it back in with Sidekiq::Extensions.enable_delay! in your initializer until this is decoupled

@krisleech krisleech changed the title Make work in Rails 5 development environment Make work with Sidekiq 5 Jun 16, 2017
@krisleech
Copy link
Owner Author

@rromanchuk Indeed that is what I meant, fixed. Thanks.

@krisleech
Copy link
Owner Author

If anyone fancies taking a stab at this please do, it should not be too tricky, I just don't have time right now.
It might even be best to copy/paste the #delay code from sidekiq < 5 in to the broadcaster so it works exactly the same as it always has.

@krisleech
Copy link
Owner Author

I have started work on this in branch sidekiq5-compatibility. It can be used with any version of sidekiq. If using Sidekiq 5 then Sidekiq::Extensions.enable_delay! is no longer needed.

Please report back any success/failures.

This change will also allow full control over how we interact with Sidekiq, allowing, for example, the queue to be specified, in a future PR.

@krisleech
Copy link
Owner Author

fixed in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants