Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1: spammed with warnings #89

Closed
quakemmo opened this issue Jan 14, 2022 · 2 comments
Closed

PHP 8.1: spammed with warnings #89

quakemmo opened this issue Jan 14, 2022 · 2 comments

Comments

@quakemmo
Copy link

quakemmo commented Jan 14, 2022

Great job, this is a very useful piece of code.
Small issue here with PHP 8.1:

  • Operating System: <Linux | Windows | OS X>
    Linux

  • PHP Version: <5.6 | 7.0 | ...>
    PHP 8.1

  • php-mysql-replication Version: <1.0.0>
    1.0.0

  • *mysql version
    Oracle-MYSQL 8.0.27

Steps required to reproduce the problem.

1. Run the dump_events.php
2. Get spammed by deprecated warnings

Expected Result.
Not get spammed by warnings

Actual Result.

Return type of MySQLReplication\Event\EventInfo::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /<path>/vendor/krowinski/php-mysql-replication/src/MySQLReplication/Event/EventInfo.php on line 100

@Moln
Copy link
Contributor

Moln commented Jan 10, 2023

You can try this fork https://github.com/Moln/php-mysql-replication .

Resolve these issues:

  • Add regular expression matching support for DatabasesOnly or TablesOnly of Config.
  • Resolve Let's Config static properties to non-static. #94, change static config properties to non-static.
  • Add retry feature.
    (new ConfigBuilder())
      ->withRetry(-1) // Retry always.
      ->withRetry(0)  // Disable retry feature. (Default)
      ->withRetry(2)  // Retry twice.
  • PHP 8.1,8.2 supports.

@krowinski
Copy link
Owner

8.1 no more supported move to 8.2 with version #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants