Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issue when updating from non-deterministic subwallet -> to deterministic #42

Open
f-r00t opened this issue Jul 24, 2023 · 2 comments

Comments

@f-r00t
Copy link
Member

f-r00t commented Jul 24, 2023

Some users have been complaining about issues with sending messages when updating from 1.3.0 > 1.3.1. Potenitally this is because of the update to deterministic wallets. Additional information is required.

@n9lsjr
Copy link
Contributor

n9lsjr commented Jul 24, 2023

I think the problem is here: https://github.com/kryptokrona/hugin-mobile/blob/master/src/HuginUtilities.js#L390

Due to some "old" users still have the old subwallet as no. 2, you will need to enforce a blank second address and instead use no. 3 as your new "messageSubwallet" like this : let [mainWallet, subWallet, messageSubWallet] = js_wallet.subWallets.getAddresses()

@n9lsjr
Copy link
Contributor

n9lsjr commented Jul 24, 2023

Check this https://github.com/kryptokrona/hugin-desktop/blob/main/src/backend/electron.cjs#L1431

It creates a blank second address and creates the deterministic messageSubwallet aswell. Seems to work for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants