Allow authenticators to set CORS headers #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apia currently always sets very permissive CORS headers because it has never been designed to work with any API which is authenticated on the presence of a cookie and thus CORS has not been issue as authentication should always be provided along with the request.
However, to allow for greater flexibility, this PR introduces the ability for authenticators to set CORS headers on responses without them being overridden later by the default.
The original default remains permissive (and by that I mean the
'Access-Control-Allow-Origin
header will return*
and theAccess-Control-Allow-Methods
will also return*
.Usage
To use this, you simply need to define appropriate values within your authenticator.
The
origin
can only contain a single hostname so if you support multiple hosts, you'll need to provide logic to return the appropriate value.