-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any plans to support ESLint? #19
Comments
Actually, the TSLint itself is going to be deprecated soon. See, TSLint's README:
See also, TSLint in 2019 post on Medium:
There is some interesting discussion in the Roadmap: TSLint → ESLint issue (palantir/tslint#4534). I'd love to keep using TypeStrict as my recommended linter config for the projects that I work on, so it would be good to know what is the plan regarding the TSLint deprecation. |
Since TypeStrict is using SonarTS and tslint-microsoft-contrib and both of them are moving to ESLint, here is some some relevant info:
There is a tslint-to-eslint-config migration tool. Currently run on the TypeStrict config it outputs: module.exports = {
"env": {
"browser": true,
"es6": true
},
"parser": "@typescript-eslint/parser",
"parserOptions": {
"project": "tsconfig.json",
"sourceType": "module"
},
"plugins": [
"@typescript-eslint",
"@typescript-eslint/tslint"
],
"rules": {
"@typescript-eslint/await-thenable": "error",
"@typescript-eslint/no-floating-promises": "error",
"@typescript-eslint/no-misused-new": "error",
"@typescript-eslint/no-use-before-declare": "error",
"@typescript-eslint/restrict-plus-operands": "error",
"constructor-super": "error",
"no-invalid-this": "error",
"no-restricted-syntax": [
"error",
"ForInStatement"
],
"use-isnan": "error",
"@typescript-eslint/tslint/config": [
"error",
{
"rules": {
"no-accessor-field-mismatch": true,
"no-all-duplicated-branches": true,
"no-collection-size-mischeck": true,
"no-dead-store": true,
"no-duplicated-branches": true,
"no-element-overwrite": true,
"no-empty-destructuring": true,
"no-gratuitous-expressions": true,
"no-identical-conditions": true,
"no-identical-expressions": true,
"no-ignored-return": true,
"no-inferred-empty-object-type": true,
"no-multiline-string-literals": true,
"no-promise-as-boolean": true,
"no-self-assignment": true,
"no-unconditional-jump": true,
"no-unthrown-error": true,
"no-unused-array": true,
"no-unused-variable": [
true,
"check-parameters",
{
"ignore-pattern": "^_"
}
],
"no-useless-cast": true,
"no-useless-increment": true,
"no-variable-usage-before-declaration": true,
"promise-must-complete": true,
"strict-comparisons": true
}
}
]
}
}; with this info:
Hopefully, as soon as both SonarTS and tslint-microsoft-contrib are migrated, it will be possible to simply convert TypeStrict to ESLint with the |
I am 100% aware of the situation :) and yes - the plan is to migrate to eslint based config as soon as it's ready.
Yes exactly - that's what I am hoping for 😆 I am thinking - maybe we should create tmp branch |
Solved! Try npm package: |
Since the core TypeScript and VS Code team is moving from TSLint to ESLint, and as ESLint is getting help from Microsoft with the TypeScript compatibility (see The future of TypeScript on ESLint) are there any plans for TypeStrict to support ESLint as well, like including an ESLint config with similar rules in addition to tslint.js?
TypeScript Roadmap: January - June 2019 - microsoft/TypeScript#29288:
TypeScript Roadmap: July - December 2019 - microsoft/TypeScript#33118:
The text was updated successfully, but these errors were encountered: