Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to limit git properties exposed #91

Closed
dslivka opened this issue Feb 9, 2014 · 3 comments
Closed

Allow to limit git properties exposed #91

dslivka opened this issue Feb 9, 2014 · 3 comments
Assignees
Milestone

Comments

@dslivka
Copy link

dslivka commented Feb 9, 2014

The plugin discloses too many properties, which may be undesirable when e.g. generated jar package is distributed. It should be possible to prevent some properties from being inserted into git.properties file, mainly:
git.commit.message.full, git.commit.message.short
git.commit.user.email, git.build.user.email
git.commit.user.name, git.build.user.name
git.remote.origin.url <- especially this one, it may even contain repo password!

Generally all properties possibly containing private sensitive information should be possible to ommit. In my case, git.commit.id.describe is the only property I need.

@ktoso ktoso modified the milestones: 2.1.8, 2.1.9 Feb 9, 2014
@ktoso ktoso self-assigned this Feb 9, 2014
@ktoso
Copy link
Collaborator

ktoso commented Feb 9, 2014

Hi @dslivka,
Thanks for the issue and bringing up these very good points - didn't think of this.

I assume the scenario is like closed source product development, and then you ship the jars to the client... Definitely see why exposing too much info here could be a big deal.

// I lol'ed @ git.remote.origin.url <- especially this one, it may even contain repo password! but certainly true! :-)

Will look at it, should not be too hard to add :-)

@ktoso
Copy link
Collaborator

ktoso commented Feb 9, 2014

Implemented :-)
3 hours from reporting... I hope it wasn't too long of a wait ;-) :shipit:

Releasing as 2.1.9, grab it from central :-)

@dslivka
Copy link
Author

dslivka commented Feb 9, 2014

Tested, 6 hours from releasing :)
Works well, thanks!!!

cardil pushed a commit to wavesoftware/maven-git-commit-id-plugin that referenced this issue Feb 24, 2014
@TheSnoozer TheSnoozer added this to the 2.1.9 milestone Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants