You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The plugin discloses too many properties, which may be undesirable when e.g. generated jar package is distributed. It should be possible to prevent some properties from being inserted into git.properties file, mainly:
git.commit.message.full, git.commit.message.short
git.commit.user.email, git.build.user.email
git.commit.user.name, git.build.user.name
git.remote.origin.url <- especially this one, it may even contain repo password!
Generally all properties possibly containing private sensitive information should be possible to ommit. In my case, git.commit.id.describe is the only property I need.
The text was updated successfully, but these errors were encountered:
Hi @dslivka,
Thanks for the issue and bringing up these very good points - didn't think of this.
I assume the scenario is like closed source product development, and then you ship the jars to the client... Definitely see why exposing too much info here could be a big deal.
// I lol'ed @ git.remote.origin.url <- especially this one, it may even contain repo password! but certainly true! :-)
Will look at it, should not be too hard to add :-)
The plugin discloses too many properties, which may be undesirable when e.g. generated jar package is distributed. It should be possible to prevent some properties from being inserted into git.properties file, mainly:
git.commit.message.full, git.commit.message.short
git.commit.user.email, git.build.user.email
git.commit.user.name, git.build.user.name
git.remote.origin.url <- especially this one, it may even contain repo password!
Generally all properties possibly containing private sensitive information should be possible to ommit. In my case, git.commit.id.describe is the only property I need.
The text was updated successfully, but these errors were encountered: