Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added custom output file option (#46) #47

Merged
merged 1 commit into from
Oct 14, 2020
Merged

feat: added custom output file option (#46) #47

merged 1 commit into from
Oct 14, 2020

Conversation

bencelang
Copy link
Contributor

Fixes #46

This solution allows for an option named outFile to be specified, relative to the project root. The provided path gets resolved through the plugin API before passed to vue-auto-routing.

Also edited the template to reflect the new functionality.

Note: Two new defaults has been added to the router instance options (mode must be specified, base for convenience).

mode: "history",
base: process.env.BASE_URL,

ktsn
ktsn requested changes Oct 11, 2020
View reviewed changes
Copy link
Owner

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. But can we leave the default value of outFile empty so that the users don't have to consider how they handle the generated file out of the box?

@bencelang bencelang force-pushed the feat/46-custom-output-path branch from cf6cabd to d809624 Compare October 13, 2020 18:09
@bencelang
Copy link
Contributor Author

Of course. I also added a touch about this to the readme, because this implementation changes the path resolution behavior compared to vue-auto-routing.

@bencelang bencelang requested a review from ktsn October 13, 2020 18:13
ktsn
ktsn approved these changes Oct 14, 2020
View reviewed changes
Copy link
Owner

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ktsn ktsn merged commit f5f2ea5 into ktsn:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktsn ktsn ktsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow custom output path to be passed to vue-auto-routing
2 participants
@bencelang @ktsn