Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: Design for enabling/disabling inflate, deflate + symlink #362

Open
JCash opened this issue Dec 1, 2024 · 1 comment
Open

Q: Design for enabling/disabling inflate, deflate + symlink #362

JCash opened this issue Dec 1, 2024 · 1 comment
Labels
question Further information is requested

Comments

@JCash
Copy link
Contributor

JCash commented Dec 1, 2024

Thanks for this great project btw, I forgot to say in my last communication!

In my case, my targets may not have all the common I/O api's (such as symlink).
Aso, I don't actually need/want to create zip archives, so it'd be good to strip that extra size from the executable.

It'd be beneficial to control this by excluding the functionality using defines.

I'd like to hear your preferences around this before I delve any deeper on this subject.

inflate/deflate

While some of the MINIZ defines may help, I think it might be good to have the defines be "owned" by your library itself.

For the extract/compress I think it's good to use a inflate/deflate wording e.g.:

  • ZIP_ENABLE_INFLATE / ZIP_ENABLE_DEFLATE

symlink

As for the stdio functions, it's less clear, as we need it for reading files, so we can't have a "diable stdio".
Instead, since the problematic function in our case is the symlink function, I propose adding something like:

  • ZIP_HAVE_SYMLINK

and if that isn't set, it should extract using full copies instead.

@JCash JCash changed the title Q: Design for enabling/disabling inflate, defalte + symlink Q: Design for enabling/disabling inflate, deflate + symlink Dec 1, 2024
@kuba--
Copy link
Owner

kuba-- commented Dec 1, 2024

How about ZIP_WITH_...:

  • ...SYMLINK
  • ...INFLATE
  • ...DEFLATE

@kuba-- kuba-- added the question Further information is requested label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants