Serialize and Deserialize implementations for ApiResource #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there. Thanks for this! I think this makes complete sense to include. I will get around to merging this before the next release, just trying to sort out a few admin things with this repo right now. |
nightkr
approved these changes
Jul 16, 2021
|
Sorry, we added a DCO check in the mean time before merging. If you're able to fix I'll merge, otherwise I'll do something similar in master. |
|
I'll fix it. |
Signed-off-by: Ole Krüger <ole@vprsm.de>
vapourismo
force-pushed
the
serde-apiresource
branch
from
db5eed7 to
f3e20c7
Compare
|
Awesome, TYVM! I'll put it in for a release tonight along with the k8s-openapi pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be great to have these very convenient traits implemented for
ApiResource.