Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix for https://github.com/clux/kube-rs/issues/494 #498

Merged
merged 1 commit into from
Apr 19, 2021
Merged

feat: fix for https://github.com/clux/kube-rs/issues/494 #498

merged 1 commit into from
Apr 19, 2021

Conversation

SachinMaharana
Copy link
Contributor

fixes #494.

nightkr
nightkr approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@nightkr nightkr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice

coadler
coadler reviewed Apr 19, 2021
View reviewed changes
Copy link
Contributor

@coadler coadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coadler
Copy link
Contributor

coadler commented Apr 19, 2021

https://github.com/kubernetes/api/blob/648b77825832f4e96433407e4b406a3bdbb988bd/admission/v1/types.go#L127

I didn't notice they changed the name in the tags 😢

@clux clux merged commit 7b04ae4 into kube-rs:master Apr 19, 2021
@clux
Copy link
Member

clux commented Apr 19, 2021

Thank you!

@clux clux mentioned this pull request May 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler left review comments

@nightkr nightkr nightkr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admission controller doesn't send message to api-server?
4 participants
@SachinMaharana @coadler @clux @nightkr