Add helper to reschedule all objects for reconciliation #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clux
reviewed
Jun 16, 2021
kube-runtime/src/controller/mod.rs
Outdated
Comment on lines
397
to
400
| /// Trigger a reconciliation for all managed objects whenever `trigger` emits a value | ||
| /// | ||
| /// For example, this can be used to reconcile all objects whenever the controller's configuration changes. | ||
| pub fn reconcile_all_on(mut self, trigger: impl Stream<Item = ()> + Send + Sync + 'static) -> Self { |
There was a problem hiding this comment.
Oh, this looks surprisingly simple!
Any chance you can put an example here for it? (can mark it no_run if it pulls in too much)
There was a problem hiding this comment.
Never actually runs (the Controller is never polled) since that would require a K8s cluster to run against.
There was a problem hiding this comment.
But it illustrates the use case well! Thank you.
Now I guess users can wrap the stream in whatever read-write protection they want and push an item into it from a http endpoint / whatever hook they want.
clux
approved these changes
Jun 20, 2021
|
released in 0.58, thanks again for all of these! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #551