avoid new dyntype defaults in Controller::owns/watches #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightkr
approved these changes
Jul 2, 2021
clux
force-pushed
the
avoid-dyntype-default
branch
from
4c6b612 to
03f9800
Compare
|
yeah, fwiw i am not super happy about it either. |
soenkeliebau
added a commit
to stackabletech/operator-rs
that referenced
this pull request
Aug 4, 2021
Due to kube-rs/kube#575 we had to change the where clauses on the owns function, as this doesn't support DynamicTypes anymore. This _should_ not require any changes in the operators themselves, as we don't currently use DynamicTypes. Might break for people who do though.
soenkeliebau
added a commit
to stackabletech/operator-rs
that referenced
this pull request
Aug 4, 2021
Due to kube-rs/kube#575 we had to change the where clauses on the owns function, as this doesn't support DynamicTypes anymore. This _should_ not require any changes in the operators themselves, as we don't currently use DynamicTypes. Might break for people who do though.
soenkeliebau
added a commit
to stackabletech/operator-rs
that referenced
this pull request
Aug 4, 2021
Due to kube-rs/kube#575 we had to change the where clauses on the owns function, as this doesn't support DynamicTypes anymore. This _should_ not require any changes in the operators themselves, as we don't currently use DynamicTypes. Might break for people who do though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small follow-up to #571