Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump k8s-openapi 0.13.0 and revert option unpacking - fixes #581 #616

Merged
merged 4 commits into from
Aug 9, 2021

Conversation

clux
Copy link
Member

@clux clux commented Aug 9, 2021

reverts unpacking from #531 while bumping k8s-openapi for https://github.com/Arnavion/k8s-openapi/releases/tag/v0.13.0

clux added 2 commits August 9, 2021 09:17
Signed-off-by: clux <sszynrae@gmail.com>
@clux
Copy link
Member Author

clux commented Aug 9, 2021

Cargo-deny on tar:

Solution: No safe upgrade is available! 🙆‍♂️

clux added 2 commits August 9, 2021 11:39
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@lfrancke
Copy link
Contributor

lfrancke commented Aug 9, 2021

I'll open a PR to fix the CI (cargo deny). That was my fault. An advisory shouldn't block a PR.

@clux
Copy link
Member Author

clux commented Aug 9, 2021

@lfrancke It's not actually blocking it, and we're not using it as a required status, so it's OK. It's just a bit annoying that advisories can be released without fixes. We got an issue about the same thing which was reasonable.

@lfrancke
Copy link
Contributor

lfrancke commented Aug 9, 2021

Okay. In theory I thought github actions is set up to ignore errors from the advisories run but for some reason it doesn't.
We just hit the same today and fixed it like this.: https://github.com/stackabletech/agent-integration-tests/pull/53/files

I don't understand why the original/current version doesn't work but I'm happy to create a PR if you like.

@clux
Copy link
Member Author

clux commented Aug 9, 2021

Yeah, very happy to take a PR for only doing the license ban on PR if you have time. The red cross will show up in places and will be a bit annoying. The issues for advisories are probably sufficient.

@clux clux merged commit ae92f05 into master Aug 9, 2021
@clux clux deleted the k8s-bump branch August 9, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants