Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube super-crate #651

Closed
clux opened this issue Oct 12, 2021 · 2 comments · Fixed by #652
Closed

kube super-crate #651

clux opened this issue Oct 12, 2021 · 2 comments · Fixed by #652

Comments

@clux
Copy link
Member

clux commented Oct 12, 2021

Something I've been wanting for a long time, but have been put up because of how it's going to be done.

Raising it again now, because once there's some agreement on delineation in #642, we ought to do this to fix dependabot issues (users get dependabot issues for kube and kube_runtime separately, which is incompatible with our versioning policy).

=> kube is a facade crate only the only thing users depend on

@nightkr
Copy link
Member

nightkr commented Oct 12, 2021

👍 for me. One thing that we've ran inte at @stackabletech is that derive macros make facades a bit tricky. Essentially, the macro has no idea about whether to refer to the traits that it interacts with using the original crate (which means that everyone still needs to pull in the direct dependency) or the facade crate (preventing direct imports which allow cargo to optimize compilation slightly).

One way to work around this would be to have an attribute for overriding the path to kube (and any other crates used).

@clux
Copy link
Member Author

clux commented Oct 23, 2021

this was released in 0.62.0 🎉

@clux clux mentioned this issue Nov 21, 2021
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants