Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to upgrade? #83

Open
comminutus opened this issue Jan 14, 2024 · 10 comments
Open

How to upgrade? #83

comminutus opened this issue Jan 14, 2024 · 10 comments

Comments

@comminutus
Copy link

Hi there, I just noticed a new version of kube-vip-cloud-provider was released. How can I upgrade my existing deployment?

@Jamison1
Copy link

Also, how does this affect the helm chart?

@lubronzhan
Copy link
Collaborator

Hi @Jamison1 which helm chart you are referring to?

@lubronzhan
Copy link
Collaborator

Hi @comminutus please hold, we just discovered a bug in 0.0.8.
Let me fix it and make a new patch today

@lubronzhan
Copy link
Collaborator

lubronzhan commented Jan 19, 2024

We don't modify any field in manifest in this patch release , you can just update your manifest with new image version

@comminutus
Copy link
Author

@lubronzhan you mean something like: kubectl -n kube-system edit deploy kube-vip-provider and change the image value from: ghcr.io/kube-vip/kube-vip-cloud-provider:v0.0.7 to ghcr.io/kube-vip/kube-vip-cloud-provider:v0.0.8 (or whatever the latest version is) ?

@Jamison1
Copy link

@lubronzhan I actually had to build my own helm chart due to this issue. My comment about how 0.0.8 affects the helm chart references the cloud provider helm chart. I tried just swapping out the image in the cloud provider helm chart and had issues. No time lately to debug it.

@lubronzhan
Copy link
Collaborator

yes @comminutus , or just kubectl apply -f https://github.com/kube-vip/kube-vip-cloud-provider/blob/main/manifest/kube-vip-cloud-controller.yaml once we bumped to 0.0.9

@Jamison1 it should affect helm chart as well. it might not affect existing svc, but it will affect service you deploy in the future.
Unless you set KUBEVIP_NAMESPACE in the config to some hardcoded namespace

@comminutus
Copy link
Author

@lubronzhan odd, I get this:

k apply -f https://github.com/kube-vip/kube-vip-cloud-provider/blob/main/manifest/kube-vip-cloud-controller.yaml
error: error parsing https://github.com/kube-vip/kube-vip-cloud-provider/blob/main/manifest/kube-vip-cloud-controller.yaml: error converting YAML to JSON: yaml: line 203: mapping values are not allowed in this context

@comminutus
Copy link
Author

Upgrading via editing the deployment worked though

@lubronzhan
Copy link
Collaborator

lubronzhan commented Jan 25, 2024

Oh sorry my bad @comminutus , it should be the raw code

so

kubectl apply -f https://raw.githubusercontent.com/kube-vip/kube-vip-cloud-provider/main/manifest/kube-vip-cloud-controller.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants