Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save Suggestion state after deployment is deleted #1062

Closed
andreyvelich opened this issue Feb 19, 2020 · 6 comments
Closed

Save Suggestion state after deployment is deleted #1062

andreyvelich opened this issue Feb 19, 2020 · 6 comments

Comments

@andreyvelich
Copy link
Member

/kind feature

Katib should have functionality to save Suggestion state somewhere besides Suggestion pod.
Some users would like to resume Experiments, but they don't want to have always running Suggestion deployment. For example we can use PV.

We can use ResumeExperiment flag from here: #1061 to specify resuming experiment mechanism.

/cc @johnugeorge @gaocegege @hougangliu @richardsliu

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
feature 0.89

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@andreyvelich
Copy link
Member Author

/priority p0

@andreyvelich
Copy link
Member Author

@johnugeorge @gaocegege What do you think about saving Suggestion states using object serialisation, e.g pickle in Python: https://docs.python.org/3/library/pickle.html.
I believe Fairing also uses pickle to serialise training code.

In that case, if ResumeExperiment: Always, after each GetSuggestion call, Suggestion can create pickle file with the current object state. Each suggestion has <AlgorithmNameService> class. For example:

class HyperoptService(api_pb2_grpc.SuggestionServicer, HealthServicer):
.

Then, we can save this pickle file in PV and use it to resume experiment with appropriate state for the Suggestion service class

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/katib 0.78

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@gaocegege
Copy link
Member

The approach LGTM if the suggestion is implemented in Python. But I prefer a general solution for different languages.

@andreyvelich
Copy link
Member Author

Let's discuss implementation here: #1250.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants