-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store vendor code or not #151
Comments
Including vendor is making it really difficult to review the PRs. I'd be in favor of removing vendor at least for now just for that reason. |
I am supportive of removing the vendor code from Katib. Agree that it is much easier to review the PRs without vendor folder. |
I think if we use dep, and we definitely can remove vendor from git. |
@jlewi @vinaykakade @gaocegege Thanks. |
Including vendor code in this repo makes difficult to review.
#142 (comment)
#141 (comment)
https://github.com/golang/dep/blob/master/docs/FAQ.md#should-i-commit-my-vendor-directory
It's the only way to get truly reproducible builds, as it guards against upstream renames, deletes and commit history overwrites.
You don't need an extra dep ensure step to sync vendor/ with Gopkg.lock after most operations, such as go get, cloning, getting latest, merging, etc.
Your repo will be bigger, potentially a lot bigger, though prune can help minimize this problem.
PR diffs will include changes for files under vendor/ when Gopkg.lock is modified, however files in vendor/ are hidden by default on GitHub.
We can protect it from deletion of depending repository by including vendor folders.
I think the more Katib mature, the less vendored folders change.
WDYT
@jlewi @vinaykakade @gaocegege
The text was updated successfully, but these errors were encountered: