Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store vendor code or not #151

Closed
YujiOshima opened this issue Aug 20, 2018 · 4 comments
Closed

Store vendor code or not #151

YujiOshima opened this issue Aug 20, 2018 · 4 comments

Comments

@YujiOshima
Copy link
Contributor

Including vendor code in this repo makes difficult to review.
#142 (comment)
#141 (comment)

https://github.com/golang/dep/blob/master/docs/FAQ.md#should-i-commit-my-vendor-directory

  • Pros

It's the only way to get truly reproducible builds, as it guards against upstream renames, deletes and commit history overwrites.
You don't need an extra dep ensure step to sync vendor/ with Gopkg.lock after most operations, such as go get, cloning, getting latest, merging, etc.

  • Cons

Your repo will be bigger, potentially a lot bigger, though prune can help minimize this problem.
PR diffs will include changes for files under vendor/ when Gopkg.lock is modified, however files in vendor/ are hidden by default on GitHub.
We can protect it from deletion of depending repository by including vendor folders.

I think the more Katib mature, the less vendored folders change.

WDYT
@jlewi @vinaykakade @gaocegege

@jlewi
Copy link
Contributor

jlewi commented Aug 21, 2018

Including vendor is making it really difficult to review the PRs. I'd be in favor of removing vendor at least for now just for that reason.

@vinaykakade
Copy link
Contributor

I am supportive of removing the vendor code from Katib. Agree that it is much easier to review the PRs without vendor folder.

@gaocegege
Copy link
Member

I think if we use dep, and we definitely can remove vendor from git.

@YujiOshima
Copy link
Contributor Author

@jlewi @vinaykakade @gaocegege Thanks.
I will remove vendor code from Katib repo.
We will only maintain only Gopkg.lock and Gopkg.toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants