Add validating webhooks for early stopping experiment

[tenzen-y]

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

Currently, there are no validating webhooks for early stopping, so users can not notice wrong parameters until to start trial Pod.
So, I'd like to add validating webhooks for the following parameters.

• spec.earlyStopping.algorithmName
• spec.earlyStopping.algorithmSettings

What do you think?

/assign

[tenzen-y]

Does it sound good ? @andreyvelich @gaocegege @johnugeorge

[andreyvelich]

Thank you for creating this!
Do you mean similar to ValidateAlgorithm ?

[tenzen-y]

Thank you for your comment!
Yes, I consider it is better to implement it using GetEarlyStoppingConfigData.

[andreyvelich]

Sounds good!

[tenzen-y]

I take this Issue.

[tenzen-y]

@andreyvelich
I found there are no unit tests for GetFooConfigData(ex. GetSuggestionConfigData) in katibconfig when I was implementing unit tests for this Issue. Are they being tested anywhere?

[tenzen-y]

I'd like to create PR to add unit tests for GetFooConfigData (ex. GetSuggestionConfigData) before resolving this issue.

[andreyvelich]

You are right @tenzen-y.
Currently, only composer tests GetSuggestionConfig, but it doesn't cover all test-cases.

[tenzen-y]

Thank you for your answer! @andreyvelich
First, I'd like to implement unit tests for GetFooConfigData.