Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should MutatingWebhook failurePolicy be Ignore? #1946

Closed
ca-scribner opened this issue Sep 2, 2022 · 3 comments · Fixed by #2018
Closed

Should MutatingWebhook failurePolicy be Ignore? #1946

ca-scribner opened this issue Sep 2, 2022 · 3 comments · Fixed by #2018

Comments

@ca-scribner
Copy link
Contributor

/kind feature

Describe the solution you'd like
Not sure if this is a bug or a feature request, but the MutatingWebhook failurePolicys are set to Ignore, which means it is easy to not notice if your webhook calls are failing. This was noticed when debugging #1795.

Is this the best configuration? Are there cases where having the Experiment and Pod mutations fail can still lead to viable setups? If there are not, maybe failurePolicy: Fail would be better so configuration errors are easier to find.


Love this feature? Give it a 👍 We prioritize the features with the most 👍

@johnugeorge
Copy link
Member

/cc @anencore94
/cc @tenzen-y

@tenzen-y
Copy link
Member

tenzen-y commented Sep 4, 2022

Thanks for reminding me! @johnugeorge
I agree with @ca-scribner.

@anencore94
Copy link
Member

I agree with you too. It would be better for safe use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants