-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discussion] The future of Trial metadata parameters. #2390
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
/remove-lifecycle stale |
In my project I would like to know the experiment name and trial name:
as these values may be generated by K8S. It would be nice to also know the namespace:
as well, even though that value may be known. For my project, I also need
but I suppose Katib does not necessarily know it's external-facing base URL and so I can inject that value into the container envs myself. I compute the experiment url and trial url from the base URL, namespace and names. If the URLs are not stable, we can consider also exposing the relative URLs of the experiment and trial:
Not sure that's worth doing or how they should be named. Currently I am not sure how to construct the trial url though, see #2474. |
Could you please pin this issue so that more people can join the discussion? @andreyvelich |
I think it's a good idea to pass corresponding experiment name and the namespace to the env of Pod! As for the url, I'm not sure if we need to pass it to the pod. WDYT👀 @kubeflow/wg-automl-leads @tariq-hasan @helenxie-bit |
As we discuss in issue #2369 , we choose to always pass the Trial name as env variable
KATIB_TRIAL_NAME
to the training container. And we implemented this feature as functionmutatePodEnv
and used it here:katib/pkg/webhook/v1beta1/pod/inject_webhook.go
Lines 140 to 142 in 206fe1c
Here are some discussions about it: #2369 (comment) #2369 (comment) #2369 (comment)
We use this issue to track the discussion. Any suggestions are welcome!
The text was updated successfully, but these errors were encountered: