Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the kubernetes object's status with server-side apply #2271

Open
tenzen-y opened this issue Mar 4, 2024 · 10 comments · May be fixed by #2435
Open

Update the kubernetes object's status with server-side apply #2271

tenzen-y opened this issue Mar 4, 2024 · 10 comments · May be fixed by #2435
Assignees
@aditya7302 @gjyotin305
Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature

Comments

@tenzen-y
Copy link
Member

tenzen-y commented Mar 4, 2024

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
I'd like to replace the client-side apply with the server-side apply when the controller updates the any statuses like

katib/pkg/controller.v1beta1/experiment/experiment_controller_status.go

Line 27 in fc858d1

func (r *ReconcileExperiment) updateStatus(instance *experimentsv1beta1.Experiment) error {
.

Server-side applies allow us to avoid updating errors due to conflicts, and then it would reduce confusions for users.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Love this feature? Give it a 👍 We prioritize the features with the most 👍
@Electronic-Waste Electronic-Waste removed their assignment Mar 25, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@andreyvelich
Copy link
Member

/help
/good-first-issue

@google-oss-prow Google OSS Prow
Copy link

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@google-oss-prow google-oss-prow bot added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 24, 2024
@aditya7302
Copy link

@andreyvelich I would like to work on this issue. Can you assign it to me ?

@andreyvelich
Copy link
Member

Thank you for your time @aditya7302!
/assign @aditya7302

@gjyotin305
Copy link

Can I work on this @andreyvelich ? Now ?

@gjyotin305
Copy link

@tenzen-y can I work on this ?

@tenzen-y
Copy link
Member Author

@tenzen-y can I work on this ?

Feel free to take this issue with /assign comment.

@gjyotin305
Copy link

@tenzen-y can I work on this ?

Feel free to take this issue with /assign comment.

Thank you

/assign @gjyotin305

@gjyotin305 gjyotin305 linked a pull request Sep 26, 2024 that will close this issue
Open
1 task
@gjyotin305
Copy link

Hi @tenzen-y could you check it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aditya7302 aditya7302

@gjyotin305 gjyotin305

Labels
good first issue Good for newcomers help wanted Extra attention is needed kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Server side apply gjyotin305/katib
5 participants
@andreyvelich @tenzen-y @Electronic-Waste @aditya7302 @gjyotin305